On Tue, Sep 6, 2011 at 3:17 PM, Thomas Guettler <h...@tbz-pariv.de> wrote: > > > Am 03.09.2011 16:13, schrieb Luke Plant: >> On 25/08/11 00:39, Russell Keith-Magee wrote: >> >>> On principle, I have no objection to the idea of making the admin >>> templates more robust in the presence of TEMPLATE_STRING_IF_INVALID; >>> adding dummy values in the context sounds like a reasonable approach >>> -- *if* doing this doesn't undermine broader error handling in the >>> templates. >> >> If we call this a bug, and agree to fix it, does it mean that from now >> on for any changes to the admin template we have to be careful to test >> with TEMPLATE_STRING_IF_INVALID != '' ? >> >> That sounds kind of tedious, and I would be against making a promise >> never to break this again in the future. If we can fix it now with >> relatively little incovenience, fine, but I don't want that to turn into >> a promise. > > If the django core makes a promise that > TEMPLATE_STRING_IF_INVALID=RaiseMissingVariable() is > supported in admin (and other contrib apps), I will help to get it done. > > Up to now, that's why I don't use the template language in my apps. > > Zen of Python: Errors should never pass silently.
This particular argument fails because we're not talking about Python, here. We're talking about a template language that renders to a public facing output. Errors on user-facing code isn't cool. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
