I would be +1 for Black. I think it makes a lot of sense for a project like Django, and it does seem that a non trivial amount of both contributor and reviewer time is spent on formatting fixes.
The choice of double quotes by default used to annoy me, but after using black for a while I think that the benefits outweigh the downsides. One thing we have not considered here is that after running black on Django a huge portion of our outstanding merge requests will have conflicts, some of which might be tricky to rebase. I’m not sure there is much we can do about that though. Tom > On 17 Apr 2019, at 09:26, Tobias Kunze <r...@rixx.de> wrote: > > Hi Dan, > >> On 19-04-16 20:33:29, Dan Davis wrote: >> +1 isort >> -1 black >> >> I think that codestyle checkers are better, because you teach yourself >> proper style for python. > > I appreciate this argument, but: As Django community our primary concern > in this discussion has to be the impact black would have on the Django > code base and the Django development process – educating our > contributors cannot be a primary concern, compared to making > contributions as easy as possible. > > Tobias > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/20190417082648.miicsigxjwoevmkl%40cordelia.localdomain. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/AFFEB466-A328-4DA6-8845-F2DFB55C1ED1%40tomforb.es. For more options, visit https://groups.google.com/d/optout.
