#1510: Time is wasted in Hydration
------------------------------+---------------------------------------------
Reporter: colnector | Owner: romanb
Type: defect | Status: closed
Priority: critical | Milestone: 1.0.3
Component: Query/Hydration | Version: 1.0.2
Resolution: fixed | Keywords:
Has_test: 0 | Mystatus: Pending Core Response
Has_patch: 0 |
------------------------------+---------------------------------------------
Changes (by romanb):
* status: assigned => closed
* resolution: => fixed
Comment:
{{{
Line 176:
// It would be nice if this could be moved to the query parser but I could
not find a good place to implement it
if ( ! isset($map['parent'])) {
This is in the loop...
}}}
This code snippet is pretty new. I dont see how it can be pulled out of
the loop though.
{{{
if ( ! $relation->isOneToOne() && $driver->initRelated($prev[$parent],
$relationAlias)) {
Can't the relation type be determined outside this inner loop?
}}}
Not really, but yes it is generally possible to determine all the
isOneToOne stuff for each relation even before the main hydration loop
begins. Im not sure it would really buy something though and it would
introduce another local var to hold the results. I won't discard this
option though. Its still undecided.
--
Ticket URL: <http://trac.phpdoctrine.org/ticket/1510#comment:15>
Doctrine <http://www.phpdoctrine.org>
PHP Doctrine Object Relational Mapper
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"doctrine-svn" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.co.uk/group/doctrine-svn?hl=en-GB
-~----------~----~----~----~------~----~------~--~---
