#1510: Time is wasted in Hydration
------------------------------+---------------------------------------------
Reporter: colnector | Owner: romanb
Type: defect | Status: assigned
Priority: critical | Milestone: 1.0.3
Component: Query/Hydration | Version: 1.0.2
Resolution: | Keywords:
Has_test: 0 | Mystatus: Pending Core Response
Has_patch: 0 |
------------------------------+---------------------------------------------
Comment (by colnector):
Replying to [comment:13 romanb]:
> Those are generally a code smell and the reason why "Extract Method" is
a popular refactoring.
I agree with that but the hydration loop is a special case.
> Code inspection is much more limited than a good tool when it comes to
profiling. All i wanna say is that i will/would not apply a questionable
code change if the claim that it improves performance is not backed up by
a) a good tool or b) the difference is very obvious even in "poor man's
microtime() profiling" like in this example (3secs vs 1min)
>
> While xdebug did not show that the time is wasted by is_array it clearly
shows that its _setLastElement. So its a good hint already. (I would not
have expected that, to be honest).
So my suggestion is simple, profile with and without the changes I have
suggested and see if they affect the overall results.
--
Ticket URL: <http://trac.doctrine-project.org/ticket/1510#comment:14>
Doctrine <http://www.phpdoctrine.org>
PHP Doctrine Object Relational Mapper
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"doctrine-svn" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.co.uk/group/doctrine-svn?hl=en-GB
-~----------~----~----~----~------~----~------~--~---
