Hi
Am 22.01.26 um 08:31 schrieb Thomas Zimmermann:
Hi
Am 22.01.26 um 08:06 schrieb Icenowy Zheng:
在 2026-01-21星期三的 13:56 +0100，Thomas Zimmermann写道：
=============== 8< =================
+
+ if (irqs)
+ pr_warn("Unknown Verisilicon DC interrupt 0x%x
fired!\n", irqs);
I'd avoid pr_warn() here. This can fill your logs quickly.
Then is pr_warn_once() okay?
Yeah, warn_once should be fine.
BTW drm_warn_once() would be preferable over plain pr_warn().
+
+ return IRQ_HANDLED;
+}
=============== 8< =================
Maybe consider returning IRQ_NONE if the (irq) tests succeeds.
+ /* Fixup framebuffer address for src coordinates */
+ dma_addr += (state->src.x1 >> 16) * bpp;
bpp is deprecated and should be avoided in new code. You can compute
the
offset with drm_format_min_pitch():
drm_format_min_pitch(fb->format, 0, state->src.x1 >> 16 )
Well it seems quite difficult to track what's deprecated in the DRM
subsystem, is there anything like a bulletin?
No, you either know or find out during the review. :) We also tend to
leave comments in the code. [1]
[1]
https://elixir.bootlin.com/linux/v6.18.6/source/include/drm/drm_fourcc.h#L82
Best regards
Thomas
Thanks,
Icenowy
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
