On 3/24/2026 2:07 AM, Rob Clark wrote: > On Mon, Mar 23, 2026 at 1:13 PM Akhil P Oommen <[email protected]> > wrote: >> >> Adreno X2-85 series present in Glymur chipset supports a new mechanism >> for SKU detection. A new CX_MISC register exposes the combined (or >> final) speedbin value from both HW fuse register and the Soft Fuse >> register. >> >> Implement this new SKU detection along with a new quirk to identify the >> GPUs that has SOFT SKU support. Also, enable this quirk for Adreno X2-85 >> and add its SKU table to the catalog. >> >> Signed-off-by: Akhil P Oommen <[email protected]> >> --- >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 ++++ >> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 9 +++++- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 41 >> ++++++++++++++++++++++----- >> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 ---- >> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 1 + >> drivers/gpu/drm/msm/registers/adreno/a6xx.xml | 4 +++ >> 6 files changed, 53 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c >> b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c >> index 79a441e91fa1..d7ed3225f635 100644 >> --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c >> +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c >> @@ -1731,6 +1731,7 @@ static struct msm_gpu *a5xx_gpu_init(struct drm_device >> *dev) >> struct adreno_gpu *adreno_gpu; >> struct msm_gpu *gpu; >> unsigned int nr_rings; >> + u32 speedbin; >> int ret; >> >> a5xx_gpu = kzalloc(sizeof(*a5xx_gpu), GFP_KERNEL); >> @@ -1757,6 +1758,11 @@ static struct msm_gpu *a5xx_gpu_init(struct >> drm_device *dev) >> return ERR_PTR(ret); >> } >> >> + /* Set the speedbin value that is passed to userspace */ >> + if (adreno_read_speedbin(&pdev->dev, &speedbin) || !speedbin) >> + speedbin = 0xffff; >> + adreno_gpu->speedbin = (uint16_t) (0xffff & speedbin); >> + > > I will confess to not expecting to see a5xx changes in a patch adding > x2-85 sku detection :-) > > Maybe split the code-motion out of adreno_gpu_init() into it's own commit? >
I forgot to mention the refactor part in the commit message. Ack. Will split this patch. -Akhil > BR, > -R >
