Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The schema fails to restrict the number of MIPI DSI ports for the 1-port LT9611C variant, and the updated title inaccurately describes all variants as '2 Port'. - [Low] The YAML description uses non-standard fullwidth CJK ideographic commas instead of standard ASCII commas. --
--- Patch [1]: [PATCH v7 1/2] dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver --- commit f290f005feeeb3c95f9e36c02a61ab4f708f4e53 Author: Sunyun Yang <[email protected]> dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver This commit adds compatible strings and updates the description for the LT9611C, LT9611EX, and LT9611UXD bridge devices. > diff --git > a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > index 429a06057ae85..e0821a63d9d74 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > @@ -4,19 +4,23 @@ > $id: http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Lontium LT9611(UXC) 2 Port MIPI to HDMI Bridge > +title: Lontium LT9611(UXC/C/EX/UXD) 2 Port MIPI DSI to HDMI Bridge [Severity: Medium] Since the commit message indicates the LT9611C only supports 1 port, should the title be updated to reflect that not all of these devices are 2 port bridges? > > maintainers: > - Vinod Koul <[email protected]> > > description: | > - The LT9611 and LT9611UXC are bridge devices which convert DSI to HDMI > + The LT9611、LT9611UXC、LT9611C、LT9611EX and LT9611UXD [Severity: Low] This isn't a bug, but it looks like fullwidth CJK ideographic commas (U+3001) were used here instead of standard ASCII commas. > + are bridge devices which convert DSI to HDMI > > properties: > compatible: > enum: > - lontium,lt9611 > + - lontium,lt9611c > + - lontium,lt9611ex [Severity: Medium] Because the LT9611C is a 1-port device, should there be an allOf/if block added to restrict the number of ports for this specific compatible string? Without it, wouldn't a device tree using lontium,lt9611c silently pass dt_binding_check validation even if it defines both port@0 and port@1? > - lontium,lt9611uxc > + - lontium,lt9611uxd > > reg: > maxItems: 1 -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
