On Sun, 21 Mar 2004 14:24:41 -0800 (PST) Alex Deucher <[EMAIL PROTECTED]> wrote:
> --- Felix K_hling <[EMAIL PROTECTED]> wrote: > > On the Savage IX it freezes now, when the 3D window gets too close to > > the bottom of the screen. There is an extra allocation of 128kb at > > the > > end of the frame buffer that is not included in RamNeedeFor3D. It > > doesn't seem to be used though. > > > > Also the computation of the HW cursor location is off by one. > > > > The attached patch fixes these problems on the SavageIX. It also > > removes > > a few obviously useless lines of code. > > > > Finally I wonder why the case for disableCOB looks pretty much the > > same > > as the case with COB enabled. I guess the cobIndex will be ignored > > later, so setting it doesn't do any harm at least. But do we really > > have > > to allocate those 128KB? > > I guess that's what I get for using S3's code. Thanks for catching > these. The patch looks good. I don't see why we would would have to > allocate the 128K for the disable case, especially since it never even > gets written to the cob regs. How does the attached patch look > (untested - it's basically just yours with some further cleanups and > removes the 128K allocation)? Works ok on ProSavageDDR and SavageIX. I also tried to disable the COB on the SavageIX but that lead to lockups pretty quickly, even with 2D only. I think the problem is the hard-coded MAXFIFO that is used in the WaitQueue* functions. The current value is 32K-256 entries, which corresponds to the 128KB COB and leaves some entries free as a precaution. It seems that Savage4 and ProSavage throttle BCI access automatically when the queue is full. On SavageIX the driver really has to make sure that there is enough space on the queue before submitting commands. > > Alex > Felix ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
