- #ifndef MODULE /** Use an additional macro to avoid preprocessor troubles */ #define DRM_OPTIONS_FUNC DRM(options) @@ -93,9 +82,6 @@ #undef DRM_OPTIONS_FUNC #endif
As a general rule - if you need to check for MODULE you are usually doing something wrong...
I think for 2.4 compat in the CVS tree we probably still need to do this..
static struct pci_driver drm_driver = { .name = DRIVER_NAME, .id_table = DRM(pciidlist), - .probe = drm_probe, + .probe = DRM(probe), .remove = __devexit_p(drm_cleanup_pci), };
Introduces use of DRM()?
Until we go to a split core/driver interface, if a function isn't static it has to be DRM() so in this case it is necessary, anyways when we start going to the new system I'll be doing it all together over a number of patches..
It should be possible to avoid the whole DRM(fff) thing using linker directives to designate what symbols are exported from the final drm_xyz.o object, in the same way that static symbols don't get exported from individual object files.
Keith
------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
