On Wed, 8 Sep 2004 12:38:54 +0200, Simon 'corecode' Schubert <[EMAIL PROTECTED]> wrote: > hey, > > please forgive my ignorance, as I'm not experienced with this matter. > > int DRM(initmap)( drm_device_t *dev, unsigned int offset, unsigned int > size, int type, int flags ) > > first of all, shouldn't type and flags be the appropriate drm_map_*_t > enums?
go ahead with the change, i wasn't think about the enums when I wrote it. > and then, also concerning the declaration of drm_map_t: shouldn't be > offset and size be of type caddr_t and size_t? (if this has been > handled on list before I joined, please forgive me and tell me to RTFA) drm_map_t is compiled into X binaries so we can't change the size of it. What are the impacts of caddr_t and size_t and 64 bits? It is fine to change things as long as we don't break the existing X installations like I just did with the first version of addmap-base-2. > > just wondering... > > cheers > simon > > -- > /"\ > \ / > \ ASCII Ribbon Campaign > / \ Against HTML Mail and News > > > > -- Jon Smirl [EMAIL PROTECTED] ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel