and then, also concerning the declaration of drm_map_t: shouldn't be
offset and size be of type caddr_t and size_t? (if this has been
handled on list before I joined, please forgive me and tell me to RTFA)drm_map_t is compiled into X binaries so we can't change the size of it. What are the impacts of caddr_t and size_t and 64 bits? It is fine to change things as long as we don't break the existing X installations like I just did with the first version of addmap-base-2.
ah, all right:
caddr_t is a pointer to a kernel address. I'm not sure about current 64 bit implementations, but at least for ia32/linux/bsd sizeof(caddr_t) == sizeof(unsigned long). If this is the same on 64 bit architectures, a change would be no problem. It's just: SUS/IEEE/ISO/POSIX doesn't guarrantee the equation above.
It's about the same for size_t. size_t is a guarranteed unsigned integer to pass (memory) sizes in. for ia32/linux/bsd again, sizeof(size_t) == sizeof(unsigned [long] int).
cheers simon
-- /"\ \ / \ ASCII Ribbon Campaign / \ Against HTML Mail and News
PGP.sig
Description: This is a digitally signed message part
