On Tue, 2005-06-21 at 23:27 -0400, Jon Smirl wrote: > On 6/21/05, Jon Smirl <[EMAIL PROTECTED]> wrote: > > Second choice would be to make a new map type, DRM_VSHM. The specific > > driver would initmap the needed space at load time. The code > > implementing it would be identical to DRM_SHM, you just need another > > map type defined so that you can tell them apart. This scheme does not > > require anyone to be root and does not have a kernel DOS hole. > > So back to the original topic. > > I'll add a new map type DRM_VSHM. When initializing, the chip specific > driver needs to do something like this: > > if ((ret = drm_initmap(dev, 0, video_size, 0, _DRM_VSHM, 0))) > goto err_g1; > > The map needs to be created in the driver. Opening it up to a normal > user is a DOS hole where the kernel can be run out of memory. Use > getmap to find the map from user space.
Could you send the diff to the list for review first? I've got a patch to clean up map handling that I'm working on, and I'd like to avoid more mess. I'm not clear on why you need a new map type, if it's going to be treated like DRM_SHM everywhere. -- Eric Anholt [EMAIL PROTECTED] http://people.freebsd.org/~anholt/ [EMAIL PROTECTED] ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
