Dave Airlie wrote: >> On Monday, October 8, 2007 10:13 am Keith Whitwell wrote: >> >>> Neither 42 nor 256 are very good - the number needs to be dynamic. >>> Think about situations where an app has eg. one glyph per texture and >>> is doing font rendering... Or any reasonably complex game might use >>> >>>> 256 textures in a frame. >>>> >> So maybe the buffer count should be part of the execbuffer request >> object? Or does it have to be a separate settable parameter? >> > > I would think the kernel needs to limit this in some way... as otherwise > we are trusting a userspace number and allocating memory according to > it... > > So I'll make it dynamic but I'll have to add a kernel limit.. > > keithw: btws poulsbo uses 256 I think also.. > Hmm, yes. Although that has been bumped recently it could be changed to dynamic, though, but as Dave says, we need to impose some kind of limit to avoid DOS. Poulsbo is still using a buffer list from user-space, and there's an internal kernel array that imposes this limit.
What's a bit different, though, is that the number of relocs is fixed (by user space using a fixed-size shared memory buffer for the relocs). This is based on the assumption that user space will know how many relocs a code-block will issue, and if the limit is going to be hit, it can flush its command buffers. While I believe this is OK for Poulsbo (although complicating things), what about i915 zone rendering? Keith? /Thomas > Dave. > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > -- > _______________________________________________ > Dri-devel mailing list > Dri-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/dri-devel > ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
