> On Sept. 10, 2014, 7:19 p.m., Parth Chandra wrote: > > contrib/native/client/src/clientlib/drillClientImpl.cpp, line 19 > > <https://reviews.apache.org/r/25409/diff/1/?file=681791#file681791line19> > > > > Order of header files should be - > > > > system files (System headers, then STL, then C lib headers) > > > > third party headers (boost etc) > > > > drill public headers > > > > drill private headers > > > > drill/common.hpp is the only one that breaks the rule and can be > > included as the first file to prevent conflicts with Zookeeper headers.
will move this changes to another patch. - Xiao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25409/#review52912 ----------------------------------------------------------- On Sept. 18, 2014, 10:07 p.m., Xiao Meng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25409/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 10:07 p.m.) > > > Review request for drill and Parth Chandra. > > > Repository: drill-git > > > Description > ------- > > DRILL-1305: C++ Client. Consume QueryState message from the Drillbit. > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClientImpl.hpp 5ac158f > contrib/native/client/src/clientlib/drillClientImpl.cpp f1a165d > contrib/native/client/src/clientlib/errmsgs.hpp 437335c > contrib/native/client/src/clientlib/errmsgs.cpp 966cfc2 > contrib/native/client/src/include/drill/common.hpp 151d698 > > Diff: https://reviews.apache.org/r/25409/diff/ > > > Testing > ------- > > > Thanks, > > Xiao Meng > >
