----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25409/#review54341 -----------------------------------------------------------
contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/25409/#comment94465> The understanding was that the callback would always have a non-NULL record batch pointer. In this case however, the record batch is NULL. The querySubmitter program crashes when this code path is hit. Also, the default query results listener (and the synchronous version of the library which uses this) break because of the NULL record batch. - Parth Chandra On Sept. 18, 2014, 10:07 p.m., Xiao Meng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25409/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 10:07 p.m.) > > > Review request for drill and Parth Chandra. > > > Repository: drill-git > > > Description > ------- > > DRILL-1305: C++ Client. Consume QueryState message from the Drillbit. > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClientImpl.hpp 5ac158f > contrib/native/client/src/clientlib/drillClientImpl.cpp f1a165d > contrib/native/client/src/clientlib/errmsgs.hpp 437335c > contrib/native/client/src/clientlib/errmsgs.cpp 966cfc2 > contrib/native/client/src/include/drill/common.hpp 151d698 > > Diff: https://reviews.apache.org/r/25409/diff/ > > > Testing > ------- > > > Thanks, > > Xiao Meng > >
