> On Sept. 29, 2014, 11 p.m., Parth Chandra wrote: > > contrib/native/client/src/clientlib/drillClientImpl.cpp, line 907 > > <https://reviews.apache.org/r/25409/diff/3/?file=708334#file708334line907> > > > > This line crashes when the record batch passed in is NULL. I'm not sure > > what the result will be if we set the m_bHasData flag to true and signal > > the waiting thread but have not actually added a new record batch to the > > queue. I'm almost sure that the drill client sync API will croak. > > Basically, passing in a NULL record batch to the query results listener > > seems to violate the implicit contract that the listener will be called > > only when there are results.
I see. So we'd better handle those NULL record batch in DrillClient::processQueryResult (as I commented) instead of calling query results listener? - Xiao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25409/#review54909 ----------------------------------------------------------- On Sept. 29, 2014, 7:46 p.m., Xiao Meng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25409/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 7:46 p.m.) > > > Review request for drill and Parth Chandra. > > > Bugs: DRILL-1305 > https://issues.apache.org/jira/browse/DRILL-1305 > > > Repository: drill-git > > > Description > ------- > > DRILL-1305: C++ Client. Consume QueryState message from the Drillbit. > > > Diffs > ----- > > contrib/native/client/example/querySubmitter.cpp 17bec3c > contrib/native/client/src/clientlib/drillClientImpl.hpp 5ac158f > contrib/native/client/src/clientlib/drillClientImpl.cpp f1a165d > contrib/native/client/src/clientlib/errmsgs.hpp 437335c > contrib/native/client/src/clientlib/errmsgs.cpp 966cfc2 > contrib/native/client/src/include/drill/common.hpp 151d698 > > Diff: https://reviews.apache.org/r/25409/diff/ > > > Testing > ------- > > > Thanks, > > Xiao Meng > >
