----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25409/#review54184 -----------------------------------------------------------
contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/25409/#comment94184> Is the io_service.reset needed here? What happens if the io_service is reset and there were requests pending? If m_pListenerThread is null then there are no more requests pending, but in this case there might be a query with results pending. - Parth Chandra On Sept. 18, 2014, 10:07 p.m., Xiao Meng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25409/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 10:07 p.m.) > > > Review request for drill and Parth Chandra. > > > Repository: drill-git > > > Description > ------- > > DRILL-1305: C++ Client. Consume QueryState message from the Drillbit. > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClientImpl.hpp 5ac158f > contrib/native/client/src/clientlib/drillClientImpl.cpp f1a165d > contrib/native/client/src/clientlib/errmsgs.hpp 437335c > contrib/native/client/src/clientlib/errmsgs.cpp 966cfc2 > contrib/native/client/src/include/drill/common.hpp 151d698 > > Diff: https://reviews.apache.org/r/25409/diff/ > > > Testing > ------- > > > Thanks, > > Xiao Meng > >
