David: Thanks for your patch. I would try to verify it in real hardware.
For 4, MdePkg BaseLib X64 Thunk16.S is really used. Do you plan to update it? For ECP one, I agree to sync IA32 and X64 together unless someone has the specific request. Thanks Liming -----Original Message----- From: David Woodhouse [mailto:dw...@infradead.org] Sent: Thursday, December 12, 2013 1:39 AM To: Gao, Liming Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] Clean up hard-coded offsets and other utter bogosity in Thunk16.S. On Tue, 2013-12-10 at 13:59 +0000, Gao, Liming wrote: > David: > For 1, are you working another patch to let it work on the real platform? > If yes, I will wait for your next patch. Sent. Would be useful to actually *test* the MASM build, although (as it says in the commit message) I've validated it by manually comparing with the GCC build. After inserting NOPs to make things line up a bit better and make it easier to compare. > For 4, Yes. I agree to sync it to ECP package. And, for X64 Thunk16.S, I > expect we can clean up it. Do we want that one to be bisectable too; does anyone actually use it? Or can we just sync it over once we think the cleanups on the IA32 and X64 are done for now? -- David Woodhouse Open Source Technology Centre david.woodho...@intel.com Intel Corporation ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
