On Tue, Dec 10, 2013 at 3:40 PM, Andrew Fish <af...@apple.com> wrote: > On Dec 10, 2013, at 1:12 PM, Jordan Justen <jljus...@gmail.com> wrote: >> I don't think Andrew was suggesting that we commit a change that would >> break CLANG builds. Particularly when building BaseLib which is used >> by basically every EDK II image. >> >> I think Andrew meant, develop the code, then convert to .byte, then >> consider for a commit. > > I can #ifdef __clang__ and add the .byte to get it working for clang again. > Probably easier to temporarily break clang in TOT than to try to patch the > patches. I can also temporarily #ifdef out the unsupported code, given most > users of BaseLib probably don’t care about Thunk16.
Hmm. I guess I'm glad I don't use CLANG with EDK II. :) Maybe we should just take David up on his offer of free assembler licenses. :) Does Thunk16 currently work with CLANG? > Which brings up the > point that maybe Thunk16 should be in another lib? Perhaps. Except, I'm not sure we're allowed to make such a change to MdePkg / BaseLib. -Jordan ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
