David: You mean IA32 Thunk breaks the real hardware, but X64 Thunk doesn't it. Could you explain it in more detail?
Yes. I could sync this patch to ECP package until MdePkg one is finalized. Thanks Liming -----Original Message----- From: David Woodhouse [mailto:dw...@infradead.org] Sent: Friday, December 13, 2013 10:35 PM To: Gao, Liming Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] Clean up hard-coded offsets and other utter bogosity in Thunk16.S. On Fri, 2013-12-13 at 14:21 +0000, Gao, Liming wrote: > David: > Thanks for your patch. I would try to verify it in real hardware. Great, thanks. The GCC-built one is verified on real hardware (and under KVM) here, but not the MASM-built one. > For 4, MdePkg BaseLib X64 Thunk16.S is really used. Do you plan to > update it? Yes, probably. It offends me, but it isn't actively broken on real hardware right now, as the 32-bit one was. So I plan to update the X86 version, *and* the remaining SDM violations in the IA32 version, but they are relatively low priority tasks. Right now, I'm knee-deep in LLVM trying to make it support .code16. Although to a certain extent I think my work there was done once I filed bug 18220 and realised it didn't even manage to compile the existing .code32-translated abomination correctly either :) > For ECP one, I agree to sync IA32 and X64 together unless someone has > the specific request. Sync IA32 and X64 together? That would be non-trivial. Although perhaps the 16-bit part of the code could indeed be shared. Or do you mean that you will sync both the IA32 and X64 code at the same time from MdePkg to ECP once the dust settles? -- dwmw2 ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
