On Mon, Dec 9, 2013 at 3:21 AM, David Woodhouse <dw...@infradead.org> wrote: > On Mon, 2013-12-09 at 09:38 +0000, Gao, Liming wrote: >> 2. I see Andrew mentions llvm doesn't support 16-bit mode. So, this >> change will cause llvm/clang/Xcode build failure. Right? > > Yes. I prodded Andrew in private email about that when he didn't > respond, in fact. And we have since had the discussion about the S3 > resume trampoline which has similar issues. In that discussion, Andrew > said: > > "Given the thrash on these [other] 2 files, maybe it worth doing the GNU > native mnemonics version to get things working and then porting that > back to llvm after it is stable?"
I don't think Andrew was suggesting that we commit a change that would break CLANG builds. Particularly when building BaseLib which is used by basically every EDK II image. I think Andrew meant, develop the code, then convert to .byte, then consider for a commit. -Jordan > Given that we're already planning to do that elsewhere in EDKII, I think > it's a good idea here too. In fact, perhaps I should have answered your > question by saying "No. It won't break the LLVM build because the LLVM > build will be broken already." :) > > Let's fix things using sane mnemonics that actually say what they mean — > and then *later* once it's entirely stable we can look at making it > unmaintainable by turning it into .byte arrays or whatever we need to do > to make it build with broken toolchains... if they really haven't fixed > the toolchain by then. > > In the interim, I will personally fund a licence for GNU gas for any > affected individuals who need it to compile the code. ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
