branch: elpa/flycheck
commit e6ebb19f7bf9590a75ee11c5c7605be7a64a02e2
Author: Bozhidar Batsov <[email protected]>
Commit: Bozhidar Batsov <[email protected]>
Remove scss-lint checker
scss-lint depends on the dead Ruby Sass engine and is no longer
maintained. Users should use scss-stylelint instead.
---
doc/languages.rst | 12 --------
flycheck.el | 58 ---------------------------------------
test/specs/languages/test-scss.el | 48 --------------------------------
3 files changed, 118 deletions(-)
diff --git a/doc/languages.rst b/doc/languages.rst
index 79dae783db..559ceb9156 100644
--- a/doc/languages.rst
+++ b/doc/languages.rst
@@ -1431,18 +1431,6 @@ to view the docstring of the syntax checker. Likewise,
you may use
Flycheck checks SASS with `sass-stylelint` and SCSS with `scss-stylelint`.
- .. syntax-checker:: scss-lint
-
- Syntax-check and lint SCSS with SCSS-Lint_.
-
- .. note::
-
- This syntax checker requires SCSS-Lint 0.43.2 or newer.
-
- .. _SCSS-Lint: https://github.com/brigade/scss-lint
-
- .. syntax-checker-config-file:: flycheck-scss-lintrc
-
.. syntax-checker:: sass-stylelint
Syntax-check and lint Sass with stylelint_.
diff --git a/flycheck.el b/flycheck.el
index 09dbadce2f..04368199eb 100644
--- a/flycheck.el
+++ b/flycheck.el
@@ -227,7 +227,6 @@
scala
scala-scalastyle
scheme-chicken
- scss-lint
sass-stylelint
scss-stylelint
sh-bash
@@ -12372,63 +12371,6 @@ See URL `https://call-cc.org/'."
(t '(bold error)))))))
:modes scheme-mode)
-(defconst flycheck-scss-lint-checkstyle-re
- (rx "cannot load such file" (1+ not-newline) "scss_lint_reporter_checkstyle")
- "Regular expression to detect a missing checkstyle reporter.")
-
-(defun flycheck-parse-scss-lint (output checker buffer)
- "Parse SCSS-Lint OUTPUT from CHECKER and BUFFER.
-
-Like `flycheck-parse-checkstyle', but catches errors about
-missing checkstyle reporter from SCSS-Lint."
- (if (string-match-p flycheck-scss-lint-checkstyle-re output)
- (list (flycheck-error-new-at
- 1 nil 'error "Checkstyle reporter for SCSS-Lint missing.
-Please run gem install scss_lint_reporter_checkstyle"
- :checker checker
- :buffer buffer
- :filename (buffer-file-name buffer)))
- (flycheck-parse-checkstyle output checker buffer)))
-
-(flycheck-def-config-file-var flycheck-scss-lintrc scss-lint ".scss-lint.yml"
- :package-version '(flycheck . "0.23"))
-
-(flycheck-define-checker scss-lint
- "A SCSS syntax checker using SCSS-Lint.
-
-Needs SCSS-Lint 0.43.2 or newer.
-
-See URL `https://github.com/brigade/scss-lint'."
- :command ("scss-lint"
- "--require=scss_lint_reporter_checkstyle"
- "--format=Checkstyle"
- (config-file "--config" flycheck-scss-lintrc)
- "--stdin-file-path" source-original "-")
- :standard-input t
- ;; We cannot directly parse Checkstyle XML, since for some mysterious reason
- ;; SCSS-Lint doesn't have a built-in Checkstyle reporter, and instead ships
it
- ;; as an addon which might not be installed. We use a custom error parser to
- ;; check whether the addon is missing and turn that into a special kind of
- ;; Flycheck error.
- :error-parser flycheck-parse-scss-lint
- :modes scss-mode
- :verify
- (lambda (checker)
- (when-let
- (output (flycheck-call-checker-process-for-output
- checker nil nil "--require=scss_lint_reporter_checkstyle"))
- (let ((reporter-missing
- (string-match-p flycheck-scss-lint-checkstyle-re output)))
- (list
- (flycheck-verification-result-new
- :label "checkstyle reporter"
- :message (if reporter-missing
- "scss_lint_reporter_checkstyle plugin missing"
- "present")
- :face (if reporter-missing
- '(bold error)
- 'success)))))))
-
(flycheck-define-checker scss-stylelint
"A SCSS syntax and style checker using stylelint.
diff --git a/test/specs/languages/test-scss.el
b/test/specs/languages/test-scss.el
deleted file mode 100644
index c3ba386e37..0000000000
--- a/test/specs/languages/test-scss.el
+++ /dev/null
@@ -1,48 +0,0 @@
-;;; test-scss.el --- Flycheck Specs: SCSS -*- lexical-binding: t; -*-
-
-;; Copyright (C) 2017 Flycheck contributors
-;; Copyright (C) 2016 Sebastian Wiesner and Flycheck contributors
-
-;; This file is not part of GNU Emacs.
-
-;; This program is free software; you can redistribute it and/or modify
-;; it under the terms of the GNU General Public License as published by
-;; the Free Software Foundation, either version 3 of the License, or
-;; (at your option) any later version.
-
-;; This program is distributed in the hope that it will be useful,
-;; but WITHOUT ANY WARRANTY; without even the implied warranty of
-;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-;; GNU General Public License for more details.
-
-;; You should have received a copy of the GNU General Public License
-;; along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-;;; Commentary:
-
-;; Specs for SCSS support.
-
-;;; Code:
-
-(require 'flycheck-buttercup)
-(require 'test-helpers)
-
-(describe "Language SCSS"
- (flycheck-buttercup-def-checker-test scss-lint scss nil
- (let ((flycheck-scss-lintrc "scss-lint.yml"))
- (flycheck-buttercup-should-syntax-check
- "language/scss/lint-error.scss" 'scss-mode
- '(1 1 error "Avoid using id selectors"
- :checker scss-lint :id "IdSelector")
- '(3 16 warning "Color `red` should be written in hexadecimal form as
`#ff0000`"
- :checker scss-lint :id "ColorKeyword"))))
-
- (flycheck-buttercup-def-checker-test scss-lint scss syntax-error
- (flycheck-buttercup-should-syntax-check
- "language/scss/error.scss" 'scss-mode
- '(3 1 error "Syntax Error: Invalid CSS after \"... c olor: red\":
expected \"{\", was \";\""
- :checker scss-lint :id "Syntax")))
-
-)
-
-;;; test-scss.el ends here
