branch: elpa/flycheck
commit 211538f989811630e9ce94ac33ce2618afc0e0e0
Author: Bozhidar Batsov <[email protected]>
Commit: Bozhidar Batsov <[email protected]>
Remove xml-xmlstarlet checker
XMLStarlet has not had a release since 2014 (v1.6.1). The xml-xmllint
checker (from actively maintained libxml2) remains as an alternative.
---
doc/languages.rst | 12 +-----------
flycheck.el | 22 ----------------------
test/specs/languages/test-xml.el | 10 +---------
3 files changed, 2 insertions(+), 42 deletions(-)
diff --git a/doc/languages.rst b/doc/languages.rst
index d4ae7cee48..2ce45255aa 100644
--- a/doc/languages.rst
+++ b/doc/languages.rst
@@ -1666,17 +1666,7 @@ to view the docstring of the syntax checker. Likewise,
you may use
.. supported-language:: XML
- Flycheck checks XML with `xml-xmlstarlet` or `xml-xmllint`.
-
- .. syntax-checker:: xml-xmlstarlet
-
- Check syntax with `XMLStarlet <http://xmlstar.sourceforge.net>`_.
-
- .. defcustom:: flycheck-xml-xmlstarlet-xsd-path
- flycheck-xml-xmllint-xsd-path
-
- Location of XSD schema to validate against for `xml-xmlstarlet` and
- `xml-xmllint` respectively.
+ Flycheck checks XML with `xml-xmllint`.
.. syntax-checker:: xml-xmllint
diff --git a/flycheck.el b/flycheck.el
index 30c399ff35..9ce5009100 100644
--- a/flycheck.el
+++ b/flycheck.el
@@ -241,7 +241,6 @@
textlint
verilog-verilator
vhdl-ghdl
- xml-xmlstarlet
xml-xmllint
yaml-actionlint
yaml-jsyaml
@@ -12762,27 +12761,6 @@ See URL `https://github.com/ghdl/ghdl'."
(error line-start (file-name) ":" line ":" column ":error: " (message)
line-end))
:modes vhdl-mode)
-(flycheck-def-option-var flycheck-xml-xmlstarlet-xsd-path nil xml-xmlstarlet
- "An XSD schema to validate against."
- :type '(choice (const :tag "None" nil)
- (file :tag "XSD schema"))
- :safe #'flycheck-string-or-nil-p
- :package-version '(flycheck . "31"))
-
-(flycheck-define-checker xml-xmlstarlet
- "An XML syntax checker and validator using the xmlstarlet utility.
-
-See URL `https://xmlstar.sourceforge.net/'."
- ;; Validate standard input with verbose error messages, and do not dump
- ;; contents to standard output
- :command ("xmlstarlet" "val" "--err" "--quiet"
- (option "--xsd" flycheck-xml-xmlstarlet-xsd-path)
- "-")
- :standard-input t
- :error-patterns
- ((error line-start "-:" line "." column ": " (message) line-end))
- :modes (xml-mode nxml-mode))
-
(flycheck-def-option-var flycheck-xml-xmllint-xsd-path nil xml-xmllint
"An XSD schema to validate against."
:type '(choice (const :tag "None" nil)
diff --git a/test/specs/languages/test-xml.el b/test/specs/languages/test-xml.el
index 74bb4ce66b..d8ce77fe4b 100644
--- a/test/specs/languages/test-xml.el
+++ b/test/specs/languages/test-xml.el
@@ -28,16 +28,8 @@
(require 'test-helpers)
(describe "Language XML"
- (flycheck-buttercup-def-checker-test xml-xmlstarlet xml nil
- (let ((inhibit-message t))
- (flycheck-buttercup-should-syntax-check
- "language/xml.xml" 'nxml-mode
- '(4 10 error "Opening and ending tag mismatch: spam line 3 and with"
- :checker xml-xmlstarlet))))
-
(flycheck-buttercup-def-checker-test xml-xmllint xml nil
- (let ((flycheck-disabled-checkers '(xml-xmlstarlet))
- (inhibit-message t))
+ (let ((inhibit-message t))
(flycheck-buttercup-should-syntax-check
"language/xml.xml" 'nxml-mode
'(4 nil error "parser error : Opening and ending tag mismatch: spam
line 3 and with"
