branch: elpa/flycheck
commit 8220d00eb0c1019ffa3f1ec8f50ac28604b62867
Author: Bozhidar Batsov <[email protected]>
Commit: Bozhidar Batsov <[email protected]>
Remove protobuf-prototool checker
Prototool was archived by Uber in March 2022. The project recommends
buf as a replacement. Remove the checker and its helper function.
---
doc/languages.rst | 4 ----
flycheck.el | 17 -----------------
test/specs/languages/test-protobuf.el | 8 +-------
3 files changed, 1 insertion(+), 28 deletions(-)
diff --git a/doc/languages.rst b/doc/languages.rst
index f6157d5f9f..17390b95f3 100644
--- a/doc/languages.rst
+++ b/doc/languages.rst
@@ -1052,10 +1052,6 @@ to view the docstring of the syntax checker. Likewise,
you may use
A list of directories to resolve import directives. Relative paths
are
relative to the path of the buffer being checked.
- .. syntax-checker:: protobuf-prototool
-
- Lint with `prototool <https://github.com/uber/prototool>`_.
-
.. supported-language:: Pug
.. syntax-checker:: pug
diff --git a/flycheck.el b/flycheck.el
index cd375a50b0..b74b2e23ab 100644
--- a/flycheck.el
+++ b/flycheck.el
@@ -197,7 +197,6 @@
processing
proselint
protobuf-protoc
- protobuf-prototool
pug
puppet-parser
puppet-lint
@@ -10686,22 +10685,6 @@ See URL
`https://developers.google.com/protocol-buffers/'."
:modes protobuf-mode
:predicate (lambda () (buffer-file-name)))
-(defun flycheck-prototool-project-root (&optional _checker)
- "Return the nearest directory holding the prototool.yaml configuration."
- (and buffer-file-name
- (locate-dominating-file buffer-file-name "prototool.yaml")))
-
-(flycheck-define-checker protobuf-prototool
- "A protobuf syntax checker using prototool.
-
-See URL `https://github.com/uber/prototool'."
- :command ("prototool" "lint" source-original)
- :error-patterns
- ((warning line-start (file-name) ":" line ":" column ":" (message) line-end))
- :modes protobuf-mode
- :enabled flycheck-prototool-project-root
- :predicate flycheck-buffer-saved-p)
-
(flycheck-define-checker pug
"A Pug syntax checker using the pug compiler.
diff --git a/test/specs/languages/test-protobuf.el
b/test/specs/languages/test-protobuf.el
index 0405476235..1ffb9ebb53 100644
--- a/test/specs/languages/test-protobuf.el
+++ b/test/specs/languages/test-protobuf.el
@@ -10,12 +10,6 @@
'(2 23 error "Missing field number."
:checker protobuf-protoc)))
- (flycheck-buttercup-def-checker-test protobuf-prototool protobuf warnings
- (flycheck-buttercup-should-syntax-check
- "language/protobuf/prototool/missing_syntax.proto" 'protobuf-mode
- '(1 1 warning "No syntax specified. Please use 'syntax = \"proto2\";' or
'syntax = \"proto3\";' to specify a syntax version."
- :checker protobuf-prototool)
- '(4 3 warning "Expected \"required\", \"optional\", or \"repeated\"."
- :checker protobuf-prototool))))
+)
;;; test-protobuf.el ends here
