branch: elpa/flycheck
commit faf2b44e6a5a7dd2bcdb0428892e6c0163904ac6
Author: Bozhidar Batsov <[email protected]>
Commit: Bozhidar Batsov <[email protected]>
Remove ruby-jruby checker
JRuby is extremely niche for linting purposes. The ruby and
ruby-rubocop checkers cover the same modes and are far more
commonly used.
---
doc/languages.rst | 10 +++-------
flycheck.el | 18 ------------------
test/specs/languages/test-ruby.el | 13 +------------
3 files changed, 4 insertions(+), 37 deletions(-)
diff --git a/doc/languages.rst b/doc/languages.rst
index a53a55ccfd..15edfe9cb4 100644
--- a/doc/languages.rst
+++ b/doc/languages.rst
@@ -1204,9 +1204,9 @@ to view the docstring of the syntax checker. Likewise,
you may use
.. supported-language:: Ruby
Flycheck checks Ruby with `ruby-rubocop` and `ruby-reek`,
- falling back to `ruby` or `ruby-jruby` for basic syntax checking if those
- are not available. There's also `ruby-chef-cookstyle`, which is only
- used for Chef cookbooks.
+ falling back to `ruby` for basic syntax checking if those are not
+ available. There's also `ruby-chef-cookstyle`, which is only used
+ for Chef cookbooks.
.. syntax-checker:: ruby-rubocop
@@ -1255,10 +1255,6 @@ to view the docstring of the syntax checker. Likewise,
you may use
Check syntax with the `Ruby <https://www.ruby-lang.org/>`_ interpreter.
- .. syntax-checker:: ruby-jruby
-
- Check syntax with the `JRuby <http://jruby.org/>`_ interpreter.
-
.. syntax-checker:: ruby-chef-cookstyle
Check syntax and lint with `Cookstyle
<https://github.com/chef/cookstyle>`_.
diff --git a/flycheck.el b/flycheck.el
index 5dd2acd90e..b065d76720 100644
--- a/flycheck.el
+++ b/flycheck.el
@@ -211,7 +211,6 @@
ruby-standard
ruby-reek
ruby
- ruby-jruby
rust-cargo
rust
rust-clippy
@@ -11701,23 +11700,6 @@ See URL `https://www.ruby-lang.org/'."
:modes (enh-ruby-mode ruby-mode ruby-ts-mode)
:next-checkers ((warning . ruby-chef-cookstyle)))
-(flycheck-define-checker ruby-jruby
- "A Ruby syntax checker using the JRuby interpreter.
-
-This syntax checker is very primitive, and may break on future
-versions of JRuby.
-
-Please consider using `ruby-rubocop' instead.
-
-See URL `https://jruby.org/'."
- :command ("jruby" "-w" "-c")
- :standard-input t
- :error-patterns
- ((error line-start "SyntaxError in -:" line ": " (message) line-end)
- (warning line-start "-:" line ": warning: " (message) line-end)
- (error line-start "-:" line ": " (message) line-end))
- :modes (enh-ruby-mode ruby-mode ruby-ts-mode))
-
(flycheck-def-args-var flycheck-cargo-check-args (rust-cargo)
:package-version '(flycheck . "32"))
diff --git a/test/specs/languages/test-ruby.el
b/test/specs/languages/test-ruby.el
index ec7de3a295..4ab8cd0e34 100644
--- a/test/specs/languages/test-ruby.el
+++ b/test/specs/languages/test-ruby.el
@@ -98,12 +98,6 @@
'(5 nil error "syntax error, unexpected constant, expecting
end-of-input"
:checker ruby))))
- (flycheck-buttercup-def-checker-test ruby-jruby ruby syntax-error
- (let ((flycheck-disabled-checkers '(ruby-rubocop ruby-reek ruby)))
- (flycheck-buttercup-should-syntax-check
- "language/ruby/syntax-error.rb" 'ruby-mode
- '(5 nil error "syntax error, unexpected tCONSTANT" :checker
ruby-jruby))))
-
(flycheck-buttercup-def-checker-test (ruby-rubocop ruby-reek) ruby warnings
(flycheck-buttercup-should-syntax-check
"language/ruby/warnings.rb" 'ruby-mode
@@ -145,11 +139,6 @@
'(16 nil warning "possibly useless use of == in void context"
:checker ruby))))
- (flycheck-buttercup-def-checker-test ruby-jruby ruby nil
- (let ((flycheck-disabled-checkers '(ruby-rubocop ruby-reek ruby)))
- (flycheck-buttercup-should-syntax-check
- "language/ruby/warnings.rb" 'ruby-mode
- '(16 nil warning "Useless use of == in void context."
- :checker ruby-jruby))))))
+))
;;; test-ruby.el ends here
