Hallo Dewey, I just took a look on your last JA15 push, solving this issue.
IMHO the solution is not ideal! You changed all INI Files to use [TRAJ] MAX_LINEAR_VELOCITY, but why? This will invoke, that every user with intention to update to JA will have to modify that value, as this behavior is completely different to 2.6, 2.7 and master. Imho MAX_VELOCITY is the correct nomination, as a circular move may invoke several axis, is not linear and may be faster than the slowest joint / axis. And most code uses max_velocity too (i.e. initraj.cc). Could you please explain why you decided the way you did that? And if that stays like it is now, shouldn't be the script to update the configs be also modified to find the difference and correct that? the docs from python interface must be updated also! So you may see also, that the easier way would be to use MAX_VELOCITY as usual, instead of changing that standard to MAX_LINEAR_VELOCITY. May be I do not see the reason for the change. Norbert Am 22.06.2016 um 00:47 schrieb Dewey Garrett: > I think the change was made in joints_axes over 8 years ago and > maintained through various rebases. > > The commit which indicates that it squashes even earlier commits > is (in the rebased 17jun2016 joints_axes15 branch): > > http://git.linuxcnc.org/gitweb?p=linuxcnc.git;a=commitdiff;h=cdc073dc6068ec0e003b9d29ff1acaeb1a2c13b0 > > The change was never documented to my knowledge and only some > configuration ini files have been updated. > > The consequences of this change escaped my attention. > > The presumptive correction to ini files is to substitute: > > [TRAJ]MAX_VELOCITY --> [TRAJ]MAX_LINEAR_VELOCITY > [TRAJ]DEFAULT_VELOCITY --> [TRAJ]DEFAULT_LINEAR_VELOCITY > > [TRAJ]MAX_ACCELERATION --> [TRAJ]MAX_LINEAR_ACCELERATION > [TRAJ]DEFAULT_ACCELERATION --> [TRAJ]DEFAULT_LINEAR_ACCELERATION > > It is possible that some ini files may need different values. > > I will work on updating the .ini and .inc files in the joints_axes15 > tree and update the documentation. > > I imagine Andy will want to update the update_ini script. ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
