Hi, I believe we'd need to deal with LLVM_ROOT as well, since the fastcomp version needs to be in sync with emscripten's?
- Sylvain On 10/10/2018 02:41, Sam Clegg wrote: > TLDR: There is a field in called EMSCRIPTEN_ROOT in the config file > which in theory can be used by external tools to find the "active" > emscripten. I'm proposing to remove it. > > --- > > Maintaining this field has a cost and it can get out of sync with the > emscripten you are actually using. Imagine you run `emcc` and if > parses the config file and finds EMSCRIPTEN_ROOT pointing to different > version of emscripten. > > The two current users of EMSCRIPTEN_ROOT that I know of are the scons support: > https://github.com/kripken/emscripten/blob/incoming/tools/scons/site_scons/site_tools/emscripten/emscripten.py > And ammo.js: https://github.com/kripken/ammo.js/blob/master/make.py#L17 > > In both of these cases a better solution would be either: > 1) looks for `emcc` in the $PATH > 2) check for EMSCRIPTEN_ROOT in the environment. > > Parsing the config file is also a rather brittle solution, and > prevents us from iterating on the config file format and how its > parses. It also uses python's `eval` which is nasty. > > Any objections to following this path? > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-discuss+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
