Godot Engine reads EMSCRIPTEN_ROOT from the file specified by EM_CONFIG or ~/.emscripten. Since emcc is not usually available in PATH, if EMSCRIPTEN_ROOT is removed, it will no longer be possible to locate it automatically. The user has to either manually add emcc to PATH, or source the environment initialization script every time before they build.
As is, if `emsdk install` and `emsdk activate` have run once, just one command (invoking SCons) is enough to build Godot. Additional steps mean we'll have more users having issues with their builds. Most users building Godot with Emscripten don't know or care about working with multiple Emscripten installations. In that sense, using multiple Emscripten installations is a valid, but rare use case. On Wednesday, October 10, 2018 at 2:41:26 AM UTC+2, Sam Clegg wrote: > > TLDR: There is a field in called EMSCRIPTEN_ROOT in the config file > which in theory can be used by external tools to find the "active" > emscripten. I'm proposing to remove it. > > --- > > Maintaining this field has a cost and it can get out of sync with the > emscripten you are actually using. Imagine you run `emcc` and if > parses the config file and finds EMSCRIPTEN_ROOT pointing to different > version of emscripten. > > The two current users of EMSCRIPTEN_ROOT that I know of are the scons > support: > > https://github.com/kripken/emscripten/blob/incoming/tools/scons/site_scons/site_tools/emscripten/emscripten.py > > And ammo.js: https://github.com/kripken/ammo.js/blob/master/make.py#L17 > > In both of these cases a better solution would be either: > 1) looks for `emcc` in the $PATH > 2) check for EMSCRIPTEN_ROOT in the environment. > > Parsing the config file is also a rather brittle solution, and > prevents us from iterating on the config file format and how its > parses. It also uses python's `eval` which is nasty. > > Any objections to following this path? > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-discuss+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
