Jonathan Choate has posted comments on this change.
Change subject: engine-core: Multiple storage domains when importing VM
......................................................................
Patch Set 1: (9 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
Line 18: //TODO: revisit - template disks may come from different storage
domains
eww! I feel so unclean that I committed at TODO comment. For shame!
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 58: public class ImportVmCommand extends
MoveOrCopyTemplateCommand<ImportVmParameters> {
I saw no use for the extra code and this sums up what the class is quite
nicely. It is a type of MoveOrCopyTemplateCommand that uses ImportVmParameters.
Its a lot less typing in the tests as well.
Line 161: if(retVal) {
as you saw from my mails to devel. I would like to put all of the checks
outside the command classes eventually.
Line 275:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW);
that would be nice
Line 437: Map<Guid, Guid> imageDomainMap =
getParameters().getImageMap();
I personally would prefer to unpack the parameters class in the ctor and never
use it again but I was told that was not the general pattern for command classes
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 68: Map<Guid, Guid> destinationStorageDomainMap =
getParameters().getImageMap();
noted
Line 179: if(!retVal) {
agreed
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
Line 277: protected boolean domainIsValidDestination(storage_domains
domain) {
agreed
Line 286: protected Map<storage_domains, Integer>
getSpaceRequirementsForStorageDomains(List<DiskImage> images) {
agreed
--
To view, visit http://gerrit.ovirt.org/1067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ebc1b402194897cf2ed12f45228153e2efe153
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
