Jonathan Choate has posted comments on this change.
Change subject: engine-core: Multiple storage domains when importing VM
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 164: if(retVal) {
aw nuts. I upgraded IntelliJ and I guess it did not import the formatter!
Thanks!
Done.
Line 270: if(domainMap.isEmpty()) {
I will revisit this
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
Line 300: // protected Map<storage_domains, Integer>
getSpaceRequirementsForStorageDomains(List<DiskImage> images) {
yeah, it was late at night when I committed! thx!
--
To view, visit http://gerrit.ovirt.org/1067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ebc1b402194897cf2ed12f45228153e2efe153
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
