Jonathan Choate has posted comments on this change.
Change subject: engine-core: Multiple storage domains when importing VM
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 58: public class ImportVmCommand extends
MoveOrCopyTemplateCommand<ImportVmParameters> {
Why does there need to be consistency here? If generics are needed in the class
declaration, use them if they are not then don't.
Line 161: if(retVal) {
I had the idea AFTER I pushed this! Since I am already touching things up, I
guess I can do that.
--
To view, visit http://gerrit.ovirt.org/1067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ebc1b402194897cf2ed12f45228153e2efe153
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
