Jonathan Choate has posted comments on this change.
Change subject: engine-core: Multiple storage domains when importing VM
......................................................................
Patch Set 1: (10 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
Line 18: //TODO: revisit - template disks may come from different storage
domains
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 161: if(retVal) {
Deferring refactoring until after this change merges
Line 275:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW);
Deferring until after this patch merges. This would affect several classes and
may require large refactoring.
Line 437: Map<Guid, Guid> imageDomainMap =
getParameters().getImageMap();
Done
Line 646: addInterfacesFromTemplate();
The comment was there and didn't match the method name so I created a new
method with the more expressive name while not changing the objects interface.
Generally when I see a comment like that in front of some code it tells me that
it should really be the name of the method. that way the information is in the
code and not a comment. I'd much rather have the code encapsulate that
information than have it in a comment.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 68: Map<Guid, Guid> destinationStorageDomainMap =
getParameters().getImageMap();
Done
Line 179: if(!retVal) {
Deferring refactoring until after merge since this impacts classes outside the
change.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
Line 277: protected boolean domainIsValidDestination(storage_domains
domain) {
Done
Line 286: protected Map<storage_domains, Integer>
getSpaceRequirementsForStorageDomains(List<DiskImage> images) {
Done
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyParameters.java
Line 21: private Map<Guid, Guid> imageMap = new HashMap<Guid, Guid>();
Done
--
To view, visit http://gerrit.ovirt.org/1067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ebc1b402194897cf2ed12f45228153e2efe153
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
