Michael Kublin has posted comments on this change.
Change subject: engine-core: Uniting 2 Commands (Review Only)
......................................................................
Patch Set 2: (7 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
Line 41: */
This should be changed, it is means that we have a global lock on all
AttachUserToVmFromPool... operations and also we have a lock on AdUserId
attribute. It was bad at the removed command and should be changed in new one
Line 50: synchronized (_lockObject) {
Use == for enum comparisons
Line 139: getCompensationContext());
if we failed in AddPermission, we will continue from here with out any note
Line 144:
How these can be? vmId == Guid.Empty or check should be upper ?
Line 181: // From AttachUserToVmAndRunCommand
we also can failed in endAction. Are we still succeeded ?
Line 249:
change name to camel case
Line 265:
Also u can remove a logger
--
To view, visit http://gerrit.ovirt.org/1711
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07ef2152193880fc2db25de6774c71780e91dc27
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
