Omer Frenkel has posted comments on this change. Change subject: engine-core: Uniting 2 Commands (Review Only) ......................................................................
Patch Set 2: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java Line 41: */ i agree this lock is not the best way to solve the problem, but changing the solution need some thinking, and i don't think it should be part of the pre-started vms feature. another patch to change the locking should be send separately. Line 49: // Parameters.EntityId = VmId; the above comments are useless .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java Line 126: // AttachUserToVmFromPool(310), what does this comment say? -- To view, visit http://gerrit.ovirt.org/1711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07ef2152193880fc2db25de6774c71780e91dc27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
