Muli Salem has posted comments on this change.

Change subject: engine-core: Uniting 2 Commands (Review Only)
......................................................................


Patch Set 2: (7 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
Line 49:         // Parameters.EntityId = VmId;
Done

Line 50:         synchronized (_lockObject) {
It is not an enum, but rather a static constant.

Line 139:                             getCompensationContext());
Done

Line 144: 
I moved it to be in the else clause.

Line 181:                 // From AttachUserToVmAndRunCommand
Done

Line 249: 
Done

Line 265: 
Done

--
To view, visit http://gerrit.ovirt.org/1711
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07ef2152193880fc2db25de6774c71780e91dc27
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to