Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: Uniting 2 Commands (Review Only)
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
Line 40: private static final Object _lockObject = new Object();
What are you trying to lock here an why?
Line 254: if (!getAdUserId().equals(Guid.Empty)) {
Improvement suggestion - can't we have one stored procedure that will do that,
instead of going twice to DB?
--
To view, visit http://gerrit.ovirt.org/1711
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07ef2152193880fc2db25de6774c71780e91dc27
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
