Maor Lipchuk has uploaded a new change for review.

Change subject: core: Remove redundent update of address for device
......................................................................

core: Remove redundent update of address for device

There is no need to update the address since it is already being updated
when calling getAddress when adding a managed device for interface and
disk.

Signed-off-by: Maor Lipchuk <[email protected]>
Change-Id: I9fe8e724b8e7e6e4470db910e4e94ce645065c7c
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/53/19953/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
index 0613207..43e5145 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
@@ -734,7 +734,6 @@
         if (!VmDeviceCommonUtils.isOldClusterVersion(ovfVer)) {
             VmDevice exportedDevice = 
entity.getManagedDeviceMap().get(deviceId);
             if (exportedDevice != null) {
-                vmDevice.setAddress(exportedDevice.getAddress());
                 vmDevice.setBootOrder(exportedDevice.getBootOrder());
                 vmDevice.setIsPlugged(exportedDevice.getIsPlugged());
                 vmDevice.setIsReadOnly(exportedDevice.getIsReadOnly());


-- 
To view, visit http://gerrit.ovirt.org/19953
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fe8e724b8e7e6e4470db910e4e94ce645065c7c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to