Maor Lipchuk has posted comments on this change. Change subject: core: Remove redundent update of address for device ......................................................................
Patch Set 1: @Omer > change is not clear, i dont understand where is the other code that update > the address The other code is already implemented we already update it twice. At addImportedDisks line 707~ getAddress(entity, id) and at addImportedInterfaces line 776~ getAddress(entity, id) Those are the only two functions who calls it. > commit message only mention interface and disk, what about other? Where do we use other? @Sergey We are not sure if this VM is from 3.0, it could be that the VM does not have devices and therefore could be null there, and probably should not be updated If you want fix it, check if its possible to remove getAddress(). > will do I don't understand why address is treated different than isPlugged or isReadOnly, it doesn't make sense to me. > SInce when updating the address we check if the device is null, and on the > other properties we don't -- To view, visit http://gerrit.ovirt.org/19953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fe8e724b8e7e6e4470db910e4e94ce645065c7c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
