Omer Frenkel has posted comments on this change. Change subject: core: Remove redundent update of address for device ......................................................................
Patch Set 1: Code-Review-1 > @Omer I see you added a condition at > d4a92461954142a9fd863ebb31e2920d1fe9cd8d, can u please give your opinion > about it, regarding the 3.0 version this commit just avoid creating devices for old cluster, update code within is the same. i think this change is confusing and i don't see a reason to make it, as Sergey wrote above, i also dont like making this method update only part of the members.. -- To view, visit http://gerrit.ovirt.org/19953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fe8e724b8e7e6e4470db910e4e94ce645065c7c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
