Maor Lipchuk has posted comments on this change. Change subject: core: Remove redundent update of address for device ......................................................................
Patch Set 1: UpdateVmDevice should be a simple method which updates VM device. Now it updates VM device without updating its address, so if I want to use this method in other flow, I have to verify that I am updating adress before I am calling that method. I am finding that very inconvenient. > When we will have a method that will use it, then we will think about it, for > now we already update it before the change. Besides we only update 4 parameters, so the developer will also have to think about the other parameters as well, so what is the difference > Update is called from AddManagedDevice, I don't see a reason why updating is > done right after adding that, its absurd. Not sure this will be compatible to 3.0 where we don't have devices in VMs > If you add device with right properties in the first place you don't need to > update it, right? So, fix the root cause, don't deal with the small thing. again, the issue is compatibility with 3.0 -- To view, visit http://gerrit.ovirt.org/19953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fe8e724b8e7e6e4470db910e4e94ce645065c7c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
