Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fix problems in engine-backup.sh
......................................................................
Patch Set 1:
(3 comments)
....................................................
File packaging/bin/engine-backup.sh
Line 164: local dirname="$(dirname ${path})"
Line 165: mkdir -p "${tardir}/files/${dirname}" || logdie
"Cannot create '${tardir}/files/${dirname}"
Line 166: cp -a "${path}" "${target}/${dirname}" ||
logdie "Cannot copy ${path} to ${target}/${dirname}"
Line 167: else
Line 168: echo "Skipping not-existent ${path}"
should be at 1st block of if, to avoid indentation use:
[ -e "${path}" ] || continue
As first statement after while
Line 169: fi
Line 170: done || logdie "Cannot read ${paths}"
Line 171: }
Line 172:
Line 208: verifyConnection
Line 209: log "Restoring database backup at
${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 210: restoreDB "${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 211: output "Starting services:"
Line 212: service ovirt-engine start
not sure what you answered, but I do not think we should start engine
automatically.
Line 213: service httpd restart
Line 214: output "Note: you might need to manually fix iptables/firewalld
conf and autostart of ovirt-engine service"
Line 215: }
Line 216:
Line 251: echo "${paths}" | while read path; do
Line 252: local dirname="$(dirname ${path})"
Line 253: local backup="${TEMP_FOLDER}/files/${path}"
Line 254: if ! [ -e "${backup}" ]; then
Line 255: echo "Skipping not-existent ${path}"
same here... just add:
[ -e "${path}" ] || continue as first statement
Line 256: else
Line 257: cp -a "${backup}" "${dirname}" || logdie
"Cannot copy '${backup}' to '${dirname}'"
Line 258: selinuxenabled && restorecon -R "${path}"
Line 259: fi
--
To view, visit http://gerrit.ovirt.org/20264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I464e795627af23712696212e4589e4b8480bb8a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
