Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fix problems in engine-backup.sh
......................................................................
Patch Set 1:
(1 comment)
....................................................
File packaging/bin/engine-backup.sh
Line 208: verifyConnection
Line 209: log "Restoring database backup at
${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 210: restoreDB "${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 211: output "Starting services:"
Line 212: service ovirt-engine start
restore is INTRUSIVE NEGATIVE flow action, setup is POSITIVE flow.
you cannot tell if this is the only component that is going to be handled or if
there are other tasks for admin while performing this sensitive operation.
maybe there is work in vdsm side? maybe starting engine will cause massive vm
migration? why do we want to take any chance?
Line 213: service httpd restart
Line 214: output "Note: you might need to manually fix iptables/firewalld
conf and autostart of ovirt-engine service"
Line 215: }
Line 216:
--
To view, visit http://gerrit.ovirt.org/20264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I464e795627af23712696212e4589e4b8480bb8a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
