Alon Bar-Lev has posted comments on this change.

Change subject: packaging: Fix problems in engine-backup.sh
......................................................................


Patch Set 3:

(2 comments)

....................................................
File packaging/bin/engine-backup.sh
Line 183:               || logdie "Database backup failed"
Line 184: }
Line 185: 
Line 186: dorestore() {
Line 187:       if service ovirt-engine status > /dev/null 2>&1; then
|| ?
Line 188:               logdie "Engine service is active - can not restore 
backup"
Line 189:       fi
Line 190:       output "Restoring..."
Line 191:       log "Opening tarball ${FILE} to ${TEMP_FOLDER}"


Line 208:       verifyConnection
Line 209:       log "Restoring database backup at 
${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 210:       restoreDB "${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 211:       output "Starting services:"
Line 212:       service ovirt-engine start || die "Failed to start engine 
service"
open issue
Line 213:       service httpd restart || logdie "Failed to restart httpd"
Line 214:       output "Note: you might need to manually fix:"
Line 215:       output "- iptables/firewalld configuration"
Line 216:       output "- autostart of ovirt-engine service"


-- 
To view, visit http://gerrit.ovirt.org/20264
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I464e795627af23712696212e4589e4b8480bb8a0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to