Adam Litke has posted comments on this change. Change subject: Change versioning schema and fix tarball ......................................................................
Patch Set 8: Code-Review-1 (2 comments) Thanks for your resubmit. I just want to make sure that mom rpms remain easy to build outside of ovirt-jenkins. http://gerrit.ovirt.org/#/c/22874/8/AUTHORS File AUTHORS: Line 1: The following people have contributed to this project. Line 2: Line 3: * Adam Litke <[email protected]> In case a resubmit is required, please remove Adam Litke <[email protected]>. We are the same person and redhat.com is my current address. Line 4: * Adam Litke <[email protected]> Line 5: * Balbir Singh <[email protected]> Line 6: * Dan Kenigsberg <[email protected]> Line 7: * Doron Fediuck <[email protected]> http://gerrit.ovirt.org/#/c/22874/8/Makefile.am File Makefile.am: Line 39 Line 40 Line 41 Line 42 Line 43 You removed the rpm and srpm targets. While ovirt jenkins has scripts to build rpms, this will make it much more difficult for users to build their own rpms. Please re-add some targets similar to what vdsm uses: srpm: dist rpmbuild -ts $(if $(BUILDID),--define="extra_release .$(BUILDID)") $(DIST_ARCHIVES) rpm: dist rpmbuild -ta $(if $(BUILDID),--define="extra_release .$(BUILDID)") \ $(WITH_HOOKS) $(DIST_ARCHIVES) -- To view, visit http://gerrit.ovirt.org/22874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22 Gerrit-PatchSet: 8 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
