Alon Bar-Lev has posted comments on this change. Change subject: Change versioning schema and fix tarball ......................................................................
Patch Set 10: (5 comments) http://gerrit.ovirt.org/#/c/22874/10/configure.ac File configure.ac: Line 45: mom/Controllers/Makefile Line 46: mom/debug/Makefile Line 47: mom/HypervisorInterfaces/Makefile Line 48: mom/Policy/Makefile Line 49: tests/Makefile tabs please Line 50: ]) http://gerrit.ovirt.org/#/c/22874/10/mom.spec.in File mom.spec.in: Line 56: make %{?_smp_mflags} Line 57: Line 58: %install Line 59: rm -rf "%{buildroot}" Line 60: make DESTDIR=%{buildroot} install quotes Line 61: install -Dp contrib/momd.init "%{buildroot}"/%{_initrddir}/momd Line 62: cp -p doc/mom-balloon+ksm.conf "%{buildroot}"/%{_sysconfdir}/momd.conf Line 63: Line 64: # Move package installed documentation to the correct directory Line 58: %install Line 59: rm -rf "%{buildroot}" Line 60: make DESTDIR=%{buildroot} install Line 61: install -Dp contrib/momd.init "%{buildroot}"/%{_initrddir}/momd Line 62: cp -p doc/mom-balloon+ksm.conf "%{buildroot}"/%{_sysconfdir}/momd.conf why is this not part of automake? Line 63: Line 64: # Move package installed documentation to the correct directory Line 65: # This is needed because autoconf has no way to know whether docs are to Line 66: # be installed in a versioned or unversioned directory and thus it Line 67: # always installs them into an unversioned directory. Move it in two Line 68: # stages to avoid errors when we are already using an unversioned dir. Line 69: mv "%{buildroot}"/%{_defaultdocdir}/%{package_name} "%{buildroot}"/_tmp Line 70: mv "%{buildroot}"/_tmp "%{buildroot}"/%{_pkgdocdir} Line 71: cp -p COPYING README "%{buildroot}"/%{_pkgdocdir} why not use --docdir= when configure? Line 72: Line 73: %check Line 74: make check %{?_smp_mflags} Line 75: http://gerrit.ovirt.org/#/c/22874/10/mom/Collectors/Makefile.am File mom/Collectors/Makefile.am: Line 23: GuestQemuProc.py \ Line 24: HostKSM.py \ Line 25: HostMemory.py \ Line 26: __init__.py \ Line 27: QemuGuestAgentClient.py \ please sort these blocks -- To view, visit http://gerrit.ovirt.org/22874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22 Gerrit-PatchSet: 10 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
