Sandro Bonazzola has posted comments on this change. Change subject: Change versioning schema and fix tarball ......................................................................
Patch Set 8: (3 comments) http://gerrit.ovirt.org/#/c/22874/8/configure.ac File configure.ac: Line 9: define([VERSION_SUFFIX], [_master]) Line 10: Line 11: AC_INIT([mom], VERSION_NUMBER[]VERSION_SUFFIX, [[email protected]]) Line 12: PACKAGE_RPM_VERSION="VERSION_NUMBER" Line 13: PACKAGE_RPM_RELEASE="3.20.$(echo VERSION_SUFFIX | sed 's/^_//')" any reason for having 3.20 instead of 4? - stable release is mom-0.3.2-3.fc19.noarch.rpm - nightly is mom-0.3.2-20140110.git17d037b.fc19.noarch.rpm I suggest to take the opportunity for branching and move to next version: 0.3.3-0.0_master Line 14: PACKAGE_NAME="mom" Line 15: AC_SUBST([PACKAGE_NAME]) Line 16: AC_SUBST([PACKAGE_RPM_VERSION]) Line 17: AC_SUBST([PACKAGE_RPM_RELEASE]) Line 16: AC_SUBST([PACKAGE_RPM_VERSION]) Line 17: AC_SUBST([PACKAGE_RPM_RELEASE]) Line 18: Line 19: AC_CONFIG_AUX_DIR([.]) Line 20: AC_CONFIG_MACRO_DIR([m4]) Why are we setting this without providing macros in m4? Line 21: AC_USE_SYSTEM_EXTENSIONS Line 22: AM_INIT_AUTOMAKE Line 23: Line 24: # Automake initialization http://gerrit.ovirt.org/#/c/22874/8/mom.spec.in File mom.spec.in: Line 97: %{_initrddir}/momd Line 98: %{python_sitelib}/* Line 99: %config(noreplace) %{_sysconfdir}/momd.conf Line 100: Line 101: %changelog this is outdated Line 102: * Fri Oct 05 2012 Adam Litke <[email protected]> - 0.3.0-1 Line 103: - Upgrade to version 0.3.0 Line 104: - Upstream fixes CVE-2012-4480 Line 105: -- To view, visit http://gerrit.ovirt.org/22874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22 Gerrit-PatchSet: 8 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
