Kiril Nesenko has posted comments on this change. Change subject: Change versioning schema and fix tarball ......................................................................
Patch Set 8: (4 comments) Thanks Adam. Will ping you ))) http://gerrit.ovirt.org/#/c/22874/8/AUTHORS File AUTHORS: Line 1: The following people have contributed to this project. Line 2: Line 3: * Adam Litke <[email protected]> > In case a resubmit is required, please remove Adam Litke <[email protected]>. Done Line 4: * Adam Litke <[email protected]> Line 5: * Balbir Singh <[email protected]> Line 6: * Dan Kenigsberg <[email protected]> Line 7: * Doron Fediuck <[email protected]> http://gerrit.ovirt.org/#/c/22874/8/Makefile.am File Makefile.am: Line 39 Line 40 Line 41 Line 42 Line 43 > You removed the rpm and srpm targets. While ovirt jenkins has scripts to b Will align with most of our project. I have no problem to leave this ... but in our jenkins jobs we follow this build process: make dist rpmbuild -ts *tar.gz rpmbuild --rebuild ... Of course with git and date suffix http://gerrit.ovirt.org/#/c/22874/8/configure.ac File configure.ac: Line 9: define([VERSION_SUFFIX], [_master]) Line 10: Line 11: AC_INIT([mom], VERSION_NUMBER[]VERSION_SUFFIX, [[email protected]]) Line 12: PACKAGE_RPM_VERSION="VERSION_NUMBER" Line 13: PACKAGE_RPM_RELEASE="3.20.$(echo VERSION_SUFFIX | sed 's/^_//')" > any reason for having 3.20 instead of 4? ok Sandro Line 14: PACKAGE_NAME="mom" Line 15: AC_SUBST([PACKAGE_NAME]) Line 16: AC_SUBST([PACKAGE_RPM_VERSION]) Line 17: AC_SUBST([PACKAGE_RPM_RELEASE]) http://gerrit.ovirt.org/#/c/22874/8/mom.spec.in File mom.spec.in: Line 97: %{_initrddir}/momd Line 98: %{python_sitelib}/* Line 99: %config(noreplace) %{_sysconfdir}/momd.conf Line 100: Line 101: %changelog > this is outdated Will update Line 102: * Fri Oct 05 2012 Adam Litke <[email protected]> - 0.3.0-1 Line 103: - Upgrade to version 0.3.0 Line 104: - Upstream fixes CVE-2012-4480 Line 105: -- To view, visit http://gerrit.ovirt.org/22874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22 Gerrit-PatchSet: 8 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
