Greg Sheremeta has posted comments on this change.

Change subject: engine: refactor: add Model attribute for help tagging
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.ovirt.org/#/c/21052/9/build/doctag.py
File build/doctag.py:

Line 26: DOCTAG_SECTION = 'doctags'
Line 27: 
Line 28: RE_ANNOTATION_BASE = r"""
Line 29:     .*
Line 30:     @%s
> you're right, will fix
Done
Line 31:     \s*
Line 32:     \(
Line 33:         \s*"\s*
Line 34:         (?P<match>[^")]*)


Line 78:             mTag = __RE_TAGNAME.match(lines[i])
Line 79:             if mTag:
Line 80:                 tagName = mTag.group("match")
Line 81:                 tagComment = ""
Line 82:                 mComment = __RE_TAGCOMMENT.match(lines[i+1])
> you're right, will fix
Done
Line 83:                 if mComment:
Line 84:                     tagComment = mComment.group("match")
Line 85:                 tags[tagName] = tagComment
Line 86:     return tags


-- 
To view, visit http://gerrit.ovirt.org/21052
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to