Einav Cohen has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging ......................................................................
Patch Set 10: > I fail to understand how we can avoid it... we need to scan this common file > anyway, no? yes, but *only* this file. so if, for example, check-style or find-bugs will decide to shout at us for whatever reason, we can make the necessary adjustments only in this single file, or even tell check-style/find-bugs to ignore this file entirely (I assume that we don't want to tell check-style/find-bugs to ignore all of the GUI code files that contain a dialog instance creation...). > I just think that there should be no dependency between sources and this file > is not adding any benefit. valid point. but, as I mentioned before, I expect changes in the code and changes in the dialog-details-data (whatever file format it is in) to happen together anyway (i.e. upon adding/updating/removing dialogs to/from the code), so there isn't much "harm" in creating that dependency IMO (I agree it is not ideal). > I won't create any more noise... Just wanted to make sure you know the > alternative. your input is always appreciated - thank you. -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
