Alon Bar-Lev has posted comments on this change.
Change subject: engine: refactor: add Model attribute for help tagging
......................................................................
Patch Set 10:
>> as each constant is used one time only.
> define "used"; in your (original) method, the constant is *written* at least
> two times: in the code, and in the properties file. see the example in my
> previous comment.
Forget the property file, I just used it in the mean to balance the noise...
but created more confusion.
If I put in code setHelpTag("xxx"[, "yyyy"]) I do not need any external
metadata.
>> introducing it, forces people to touch two files each modification
> in your (original) method as well: the code, and the .properties file.
Apologize for the confusion, no property file is needed if we put all in the
setHelpTag.
I introduced it as a contra argument for this common file, to reach the
conclusion that it is not required at all.
>> I still suggest to use plain setHelpTag("id"[, "description"]) at actual
>> code, dropping this common file entirely.
> if you are referring to going back to code-scanning (i.e. treating the .java
> files as text files and scan for the entire information there) - we prefer to
> avoid that, since it requires people to write this particular piece of code
> in a very specific way (e.g. no variables, etc.), sometimes a way that is
> even considered "bad java", tomorrow it might contradict
> check-style/find-bugs/whatever issues - so this may be hard to track/enforce.
I fail to understand how we can avoid it... we need to scan this common file
anyway, no?
> The method introduced in this patch is simple, clean, and the least
> error-prone that I can think of. People are already used to updating such
> Constants .java files in the GUI code anyway due to our localization support,
> for example - so I don't think that with the currently-implemented approach
> there is a major over-"load"/complexity on the patch author here.
OK, so go ahead, I won't create any more noise, it is not that important. I
just think that there should be no dependency between sources and this file is
not adding any benefit. I might have wrote the same on several other
implementation had I seen them :)
Just wanted to make sure you know the alternative.
--
To view, visit http://gerrit.ovirt.org/21052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
